Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sql query builder #5123

Merged
merged 14 commits into from
Jan 15, 2025
Merged

Extract sql query builder #5123

merged 14 commits into from
Jan 15, 2025

Conversation

jacek-prisma
Copy link
Contributor

Extracts 2 new crates:

  • sql-query-builder with sql specific query building logic
  • query-builder, currently a stub but will hold abstractions for query building

I've moved some models around to decouple query building and query structure from the connector logic.

@jacek-prisma jacek-prisma requested a review from a team as a code owner January 14, 2025 17:33
@jacek-prisma jacek-prisma requested review from jkomyno and removed request for a team January 14, 2025 17:33
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5123 will degrade performances by 5.51%

Comparing chore/extract-sql-query-builder (06f8df6) with compiler (6b19a39)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark compiler chore/extract-sql-query-builder Change
❌ build (medium) 2.5 ms 2.6 ms -5.51%

@jacek-prisma jacek-prisma requested review from aqrln and removed request for jkomyno January 14, 2025 17:40
@aqrln aqrln added this to the 6.3.0 milestone Jan 14, 2025
aqrln
aqrln approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🙌

@aqrln aqrln merged commit 244e52c into compiler Jan 15, 2025
339 of 364 checks passed
@aqrln aqrln deleted the chore/extract-sql-query-builder branch January 15, 2025 09:40
@jacek-prisma jacek-prisma mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-prisma @aqrln